Makefile Upgrade #732
Merged
Makefile Upgrade #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a stepping stone to going to a full Makefile build system. All src files can be provided in the make and sent to build.py with minimal issues now that we don't have to build a comma separated list.
The top level makefile now handles the building of nuklear.h, docs, and demos. Doing this, not only provides a more familar interface for C programmers, but allows the build system to become simplified. Using `make` can take advantage of multiple processes and threading. Next up in the line will be updating the workflow to take advantage of these properties.
Contributor
|
Oh this is nice. Thanks so much. Before merging, is there anything else you'd like to add to it? |
Contributor
Author
|
I would prefer this get merged before I continue working on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top level makefile has been upgraded to handle the building of everything in the project. Demos are recursively built, documentation is created, and Nuklear.h gets paq'd. This does not break the previous build system, only adds a new path.
In order to make this happen, a small modification to
build.pyneeded to happen to allow space delimited lists of files. Note, this change is backwards compatible.Using the makefile at the top level for the building is not only familiar to C developers; but also provides better control and build capabilities to any automated systems. Multi-threaded building and processing, plus inherited compiler variables can help to simplify more advanced build procedures while providing a clean and common way for developers to make future adjustments.
After this update, I hope to modify the github workflow to reduce build times.