Support numpad Enter with SDL backends #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you tell a user they can submit with Enter and then it doesn't work, well... they don't care that the numpad Enter is technically a different key. They have a point, they both are labeled "Enter" on most keyboards.
I can go through the other backends adding support but before I do I want to get feedback on my approach. I can't think of any reason we'd want/need to add NK_KEY_KP_ENTER to nuklear itself because I can't think of a case we'd actually want distinct behavior for regular Enter/Return vs Numpad Enter. If anyone can think of a convincing case I'll make the internal changes instead.
In either case I would need help testing several of them, specifically the windows backends, but possibly some of the more esoteric ones as well.