Add NumPad Enter to other backends #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GL4 demo is crashing for me but it's nothing to do with my change
SFML seems to already treat both regular Return and Numpad Enter as sf:Keyboard:Enter (which I changed because sf:Keyboard:Return is deprecated. But SFML seems to have some other weird input bug.
RobLoach
approved these changes
Feb 22, 2025
sfml_input_bug.mp4Sorry for the delay. The first input seems fine but every subsequent one starts one character over and shows a ? there once you start typing and you also can't backspace. It's almost certainly an issue with the SFML backends not Nuklear itself or else we'd see it somewhere else. |
|
Definitely seems something with SFML. I haven't seen this happen in the other renderers. |
|
Made a follow up for that over at #783 . Overall, this change looks good. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RobLoach you merged my last pull request so I'm taking that as approval to make similar changes to the other backends as appropriate. I've done so to all except rawfb since that's kind of special/unfinished.
As I said before, I'm unable to easily test the Windows backends but they all use the same input method so if one works they should all work.
In the process of going through everything I found a couple issues I hope someone else can verify: