Skip to content

fix: move MCP server creation logic to mcp-server.ts to resolve circular dependency issue #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

fix: move MCP server creation logic to mcp-server.ts to resolve circular dependency issue #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@ import mcpServer from './mcp/mcp-server.js';
* It also serves as the entry point for starting the MCP server.
*/

// Local imports for internal use
import { IDBManager } from './idb/IDBManager.js';
import { NLParser } from './parser/NLParser.js';
import { MCPOrchestrator } from './orchestrator/MCPOrchestrator.js';

// Export interfaces
export { IIDBManager, SimulatorInfo, AppInfo, SessionConfig } from './idb/interfaces/IIDBManager.js';
export { IParser, ParseResult, ValidationResult } from './parser/interfaces/IParser.js';
Expand All @@ -54,23 +49,6 @@ export { MCPOrchestrator } from './orchestrator/MCPOrchestrator.js';
export { ParserToOrchestrator } from './adapters/ParserToOrchestrator.js';
export { OrchestratorToIDB } from './adapters/OrchestratorToIDB.js';

/**
* Create a complete MCP Server instance
* @returns Object with all necessary instances
*/
export function createMCPServer() {
// Create instances
const idbManager = new IDBManager();
const parser = new NLParser();
const orchestrator = new MCPOrchestrator(parser, idbManager);

return {
idbManager,
parser,
orchestrator
};
}

/**
* Main entry point for the MCP server
*
Expand Down
22 changes: 21 additions & 1 deletion src/mcp/mcp-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ import fs from 'fs';
import path from 'path';
import { fileURLToPath } from 'url';

import { createMCPServer } from '../index.js';
// Export implementations
import { IDBManager } from '../idb/IDBManager.js';
import { NLParser } from '../parser/NLParser.js';
import { MCPOrchestrator } from '../orchestrator/MCPOrchestrator.js';

// Log configuration
// Get the directory name using ESM approach
Expand All @@ -35,6 +38,23 @@ const logToFile = (message: string, level: string = 'info') => {
}
};

/**
* Create a complete MCP Server instance
* @returns Object with all necessary instances
*/
export function createMCPServer() {
// Create instances
const idbManager = new IDBManager();
const parser = new NLParser();
const orchestrator = new MCPOrchestrator(parser, idbManager);

return {
idbManager,
parser,
orchestrator
};
}

/**
* MCP Server implementation for iOS simulator
*/
Expand Down