Skip to content

Potential fix for code scanning alert no. 9: Uncontrolled data used in path expression #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

Potential fix for code scanning alert no. 9: Uncontrolled data used in path expression #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions code/src/api/v1/controllers/postRemoveBackground.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ async function myBlobToUIntDemo(blob: Blob) {

export const postRemoveBackgroundController = () => {
const persistenceHandler = new ImagesPersistenceHandler();

const baseTempDir = path.join(process.cwd(), "temp");
return async (req: Request, res: Response): Promise<void> => {
const roomId = req.params.roomId;
const imageId = req.params.imageId;
Expand All @@ -38,10 +38,14 @@ export const postRemoveBackgroundController = () => {

const extension = mimeTypes.extension(contentType) || "png";
const fileName = `${roomId}/${imageId}.${extension}`;
const filePath = path.join(process.cwd(), "temp", fileName);
const filePath = path.resolve(baseTempDir, fileName);
// Ensure that filePath is strictly inside baseTempDir
if (!filePath.startsWith(baseTempDir + path.sep)) {
res.status(400).json({ status: "KO", message: "Invalid path traversal attempt." });
return;
}

await saveBase64ToFile(dataBase64, filePath);

try {
removeBackground(filePath, {
publicPath: `file://${path.join(process.cwd(), "public")}/`,
Expand Down
Loading