Create a new Color method in the Temperature class in SimpleWeatherService for easier reusability.
#2218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
SimpleWeatherService as the method `Color` for easier reusability.
JustScott
force-pushed
the
new_temperature_method_color
branch
from
3023482 to
9204b56
Compare
mark9064
approved these changes
Feb 12, 2025
Member
mark9064
left a comment
mark9064
left a comment
There was a problem hiding this comment.
I think moving it still makes sense either way, thanks for splitting out this change :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was brought up in #2204 to move the
TemperatureColorfunction to theTemperatureclass inSimpleWeatherServiceas an easy to reuse method, however since then it has been decided to use a static temperature color in the terminal watch face instead which means theTemperatureColorfunction is only used in one file (weather.cpp) making it currently "pointless" to move this function. However, I'm still creating this PR in case others think we should still move this function to theColormethod for easy reuse in the future.