-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New App: Tally #2320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New App: Tally #2320
Conversation
|
Build size and comparison to main:
|
mark9064
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this in :)
Code looks really good overall, just a few comments. Haven't run clang-tidy yet
|
One other thing: I'm guessing this is designed to go to 999 but it seems that the numbers are slightly cut off when showing 3 digits. Maybe they could be a bit smaller so they can keep a bit of margin even at 3 digits? I think the next font size down is a lot smaller though - what do you think? |
|
Good call--I mostly anticipated usage for lower values, but I pushed another commit that changes the font when it reaches 100. This way it's still large for (what I'm guessing is) the majority of use cases, but will still work well above that. |
mark9064
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran clang-tidy, all looked good
Hehe, I counted to 863 on my Pebble smartwatch just two days ago, with a tally counter app. 😅 So it's great that it'll not stop at 100. Four digis support would be nice too but I understand if you don't wanna do that. 😊 This is a great addition to the app suite! 🙂 |
As requested by my wife--for anyone who forgets where they were when counting things.
Basic functionality is tap-to-count, but shake-to-count can be enabled (using the same calibration as shake-to-wake). Includes a delay to avoid accidental double counting, and helpful "toast" messages when options are changed.
Note that the added Adwaita Mono font is for the Tally 5 character (𝍸) which I used as the app icon. This symbol is only implemented in a bare handful of existing fonts, but Adwaita is released under the OFL so should be fine to use.