-
Notifications
You must be signed in to change notification settings - Fork 606
Support SDAR #3922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support SDAR #3922
Conversation
@@ -179,7 +183,7 @@ def _reorder_migrating(): | |||
return running_migration | |||
|
|||
@logging_timer('SchedulePrefilling', logger) | |||
def _schedule_prefill(self): | |||
def _schedule_prefill(self, prealloc_size: int = 0): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of prealloc_size
? I see it's always passed as 0 from the schedule
method. Is this intended for future use or should it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Over allocate kv cache might be useful for future models.
Does SDAR conflict with --quant-policy fp8? I tried it, it repeated meaningless words. |
@zhulinJulia24 may put JetLM/SDAR-8B-Chat, JetLM/SDAR-30B-A3B-Chat into CI |
1, | ||
num_tokens, | ||
), dtype=torch.long, device=device) | ||
seq_length = torch.ones((batch_size, ), dtype=torch.long, device=device) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seq_length should be all max_q_seqlen
, not all 1
Since we are refactoring chat template, we will use template of internlm2 for now.