[elian] Update new train method, use TrainConfig mode to change train… #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢你的贡献，不过我看 PR 的内容里，除了新增启动代码，貌似还包含了一些其他模块的更新。我们应该还是尽可能保证 PR 的独立性，不同的功能分多个 PR 提交。 |
HAOCHENYE
reviewed
Sep 12, 2025
| @@ -0,0 +1,31 @@ | |||
| import torch.distributed as dist | |||
There was a problem hiding this comment.
xtuner/v1/train/cli/sft.py
已经是一个训练入口了，这个 main 入口的差别是？
| @@ -0,0 +1,48 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
这个适合放在 tutorial 或者 examples 里，不适合放在库的核心代码里。以及这里其实有比较多的，贴近个人风格的写法，他更适合作为文档中的最佳实践的推荐写法。
此外有一些环境变量和步骤应该也不是必须的，例如 conda activate，CUDA_HOME，LD_LIBRARY_PATH 这些，不同环境下也容易失效
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
训练启动代码，拥有更多的配置信息，方便更改，只需启动sh文件即可。