Skip to content

Conversation

djibe
Copy link

@djibe djibe commented Mar 31, 2020

First PR : sets up all devDependencies + scripts to compile changes instantly.

  • updates docs and bower accordingly.

Next PR will be Material skin.

@djibe
Copy link
Author

djibe commented Mar 31, 2020

If you want to play with material skin right now : https://jsfiddle.net/djibe89/z31rxhot/17/

@IonDen IonDen self-assigned this Apr 9, 2020
@IonDen IonDen added the Feature request Request for a new functionality label Apr 9, 2020
@djibe
Copy link
Author

djibe commented Apr 23, 2020

Hi @IonDen . COuld you merge my PR so I can submet my Material skin ?

Thanks,
See you

@IonDen
Copy link
Owner

IonDen commented Apr 23, 2020

@djibe, you did not resolve 2 minor issues.

@djibe
Copy link
Author

djibe commented Apr 23, 2020

Ooops.
Tried to figure out what those 2 minor issues are.
Do you have a hint so I can fix what you don't like ?
Your fan,
djibe

@IonDen
Copy link
Owner

IonDen commented Apr 23, 2020

Ooops, sorry, I did not press the button)

@djibe djibe requested a review from IonDen April 23, 2020 20:58
@djibe
Copy link
Author

djibe commented Apr 23, 2020

Done. Thx

@djibe
Copy link
Author

djibe commented Apr 27, 2020

Hi @IonDen
Everything finally fixed :D
Thx

@IonDen
Copy link
Owner

IonDen commented Apr 27, 2020

Hi, @djibe, I will try to find some time this week to merge it.
Remember I will need not only merge it, but update a website and publish new version to NPM.

@djibe
Copy link
Author

djibe commented Apr 27, 2020

I know and I appreciate your time.
See you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Request for a new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants