Fix NaN TimeOfFlight at negative yOffset & low angle #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeOfFlight
currently returns NaN in some cases, particularly when firing angle is low and the target Y offset is negative.The function has to solve a quadradic and it gets the solution for the positive root, but sometimes the correct solution is the one for negative root.
Example for testing:
Using current implementation, the
TimeOfFlight
returns NaN and the output is:Using this PR's implementation,
TimeOfFlight
returns correct result, and the output becomes: