-
Notifications
You must be signed in to change notification settings - Fork 2
feat: 디자인 시스템 - Card 컴포넌트 구현(수정중) #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WonJuneKim
wants to merge
30
commits into
dev
Choose a base branch
from
feat/257-card-design-system
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- polymorphicForward 래핑 시 displayName을 명시할 수 있도록 처리하는 변경점
- 기존 readOnly 일 때 <button>을 가지는 의미론적 문제점에 대한 개선안
- variant 변경 이벤트를 전파할 필요가 없다고 판단
- 프리셋에 맞는 인터페이스 생성 - 프리셋은 케이스에 따라 미리 지정된 Compound의 세트입니다.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
11 tasks
…ent into feat/257-card-design-system
- 추상화된 비즈니스 레이어 내에서 다형성 구조로 사용하기 위함
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 작업 내용
💡 자세한 설명
구현한 의도를 설명해주세요.
수정 사항이 있다면 수정한 이유를 적어주세요.
필요하다면 스크린샷 또는 코드 조각을 사용해주세요.
📗 참고 자료 (선택)
📢 리뷰 요구 사항 (선택)
✅ 셀프 체크리스트
closes #257