Conversation
bpbond
approved these changes
Mar 17, 2026
inst/include/physical_constants.hpp
Outdated
|
|
||
| // The number of moles in the atmosphere | ||
| constexpr double ATMOSPHERE_MOL = 1.727e20; | ||
| constexpr double CH4_molarMass = 16.043; |
Member
There was a problem hiding this comment.
Change to ALL CAPS for consistency?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is take 2 at implementing consistent physical constants across hector components based on Ben's feedback to #801. We have added a physical_constants.hpp file where physical constants used across hector components are defined.
So far I have only implemented the change for the CH4 component & seeking feedback if this is the way we would like to continue.