support for GraphBinary serialization #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pm-osc
commented
Dec 22, 2024
pm-osc
commented
- added support for GraphBinary serialization for JanusGraph text predicate and relation identifier
- integration tests are extended with cases for testing relation identifier with string vertex ID
pm-osc
force-pushed
the
jg-binary
branch
2 times, most recently
from
56edefd to
60f7159
Compare
porunov
approved these changes
Dec 24, 2024
Signed-off-by: pm-osc <[email protected]>
FlorianHockmann
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Really cool that JanusGraph-Python now also gets support for GraphBinary! :-)
Also don't worry about the Codacy comments. We only use Codacy as a tool during review. The issues it complains about are sometimes really just noise or no issues at all. I've disabled the rule regarding not using assert in Python as we use it all the time in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.