Open
Conversation
…y readout). Created new directory common-tools/clas-jcsg/src/main/java/org/jlab/detector/geant4/v2/RECOIL/ with Geant4Factory and StripFactory. Also crated reconstruction/recoil (hits, clusters, crosses). Tested on gemc, everything seems reasonable.
…ted simulations, comparing reconstructed x,y,z to true positions
raffaelladevita
requested review from
baltzell,
c-dilks,
drewkenjo and
raffaelladevita
as code owners
Collaborator
|
@silvianic: I just updated the code from development and resolved some conflicts; can you verify the intended changes were preserved? |
raffaelladevita
requested changes
Dec 19, 2025
Collaborator
raffaelladevita
left a comment
raffaelladevita
left a comment
There was a problem hiding this comment.
This PR is related to #921, see the comments there
Collaborator
There was a problem hiding this comment.
This file should be removed since these banks were only used by old gemc versions with EVIO output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up codes and fixed shift of one strip appearing in reconstructed simulations, comparing reconstructed x,y,z to true positions