Skip to content

update: update Compile Kotlin and Java sources in Maven #4785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

update: update Compile Kotlin and Java sources in Maven #4785

wants to merge 6 commits into from

Conversation

@koshachy
Copy link
Collaborator

@koshachy koshachy commented Apr 2, 2025

No description provided.

@koshachy koshachy requested a review from a team as a code owner April 2, 2025 08:51
@koshachy koshachy force-pushed the update-kotlin-maven branch from 0772b71 to ec066ba Compare April 2, 2025 08:54
@koshachy koshachy mentioned this pull request Apr 2, 2025
Closed
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 3, 2025
@koshachy koshachy removed the Stale label May 9, 2025
@ALikhachev ALikhachev assigned ALikhachev and unassigned antohaby May 27, 2025
@koshachy koshachy force-pushed the update-kotlin-maven branch from ec066ba to b2c8aae Compare May 28, 2025 11:22
@ALikhachev
Copy link
Member

ALikhachev commented Jun 5, 2025

I would suggest additionally highlighting that in the setup Kotlin + Java, we need to let Kotlin compiler know about the Java sources, so that's why we configure ${project.basedir}/src/main/java as a source directory for Kotlin. That is required for Kotlin -> Java references.

ALikhachev
ALikhachev requested changes Jun 5, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 7, 2025
@koshachy koshachy removed the Stale label Sep 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 8, 2025
@koshachy koshachy removed the Stale label Oct 8, 2025
@koshachy koshachy mentioned this pull request Oct 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ALikhachev ALikhachev ALikhachev approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@danil-pavlov danil-pavlov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@koshachy @ALikhachev @antohaby @sarahhaggarty @danil-pavlov @mipo256