Re-enable LT2Fir function/method body elidation #5540
+343
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aviroop-123
commented
Oct 30, 2025
aviroop-123
commented
- Adds more tests for header compilation, specifically nested classes/functions.
- Fixes for nested function / method declaration.
- Re-enable LT2Fir function/method body removal & fix for test stub.
demiurg906
requested review from
demiurg906
and removed request for
FenstonSingel and
mMaxy
demiurg906
requested changes
Oct 31, 2025
.../jetbrains/kotlin/fir/resolve/transformers/body/resolve/FirDeclarationsResolveTransformer.kt
Outdated
Show resolved
Hide resolved
...fir/resolve/src/org/jetbrains/kotlin/fir/resolve/transformers/FirStatusResolveTransformer.kt
Outdated
Show resolved
Hide resolved
compiler/fir/raw-fir/raw-fir.common/src/org/jetbrains/kotlin/fir/builder/Context.kt
Show resolved
Hide resolved
...ler/fir/raw-fir/raw-fir.common/src/org/jetbrains/kotlin/fir/builder/AbstractRawFirBuilder.kt
Show resolved
Hide resolved
...ler/fir/raw-fir/raw-fir.common/src/org/jetbrains/kotlin/fir/builder/AbstractRawFirBuilder.kt
Show resolved
Hide resolved
...ler/fir/raw-fir/raw-fir.common/src/org/jetbrains/kotlin/fir/builder/AbstractRawFirBuilder.kt
Outdated
Show resolved
Hide resolved
...ee2fir/src/org/jetbrains/kotlin/fir/lightTree/converter/LightTreeRawFirDeclarationBuilder.kt
Outdated
Show resolved
Hide resolved
aviroop-123
force-pushed
the
header-compilation-lt2fir-1
branch
from
4a33595 to
27cd10b
Compare
aviroop-123
force-pushed
the
header-compilation-lt2fir-1
branch
from
27cd10b to
6fe35a1
Compare
aviroop-123
commented
Nov 3, 2025
compiler/fir/analysis-tests/testData/resolve/headerMode/enumClassDeclaration.fir.txt
Show resolved
Hide resolved
demiurg906
requested changes
Nov 4, 2025
Contributor
demiurg906
left a comment
demiurg906
left a comment
There was a problem hiding this comment.
To make future review iterations simpler, could you please don't override existing commits, but instead create fixup! commits with changes regarding review comments? You can do it using git commit <target_commit> or with the IDEA interface.
Also please rebase your branch on top of the fresh master.
They will be automatically squashed with target commits before the merge.
| isLocal = false, | ||
| overriddenFunctions.map { it.status as FirResolvedDeclarationStatus }, | ||
| ) | ||
| // Once the modality is determined, we can remove the body. |
Contributor
There was a problem hiding this comment.
This code is actually redundant and could be deleted.
inline status is not inheritable, so it checks basically the same things as the code in the raw fir builder.
…e inline functions. ^KT-78422
…'s a no-op. ^KT-78422
aviroop-123
force-pushed
the
header-compilation-lt2fir-1
branch
from
6fe35a1 to
f9a7533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.