Skip to content

[DO-NOT-MERGE] fix(manager/macos): restore app bundle ID to outline-manager #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[DO-NOT-MERGE] fix(manager/macos): restore app bundle ID to outline-manager #2405

wants to merge 1 commit into from

Conversation

@jyyi1
Copy link
Contributor

@jyyi1 jyyi1 commented Feb 20, 2025 •
edited
Loading

This PR restores the Outline Manager's CFBundleIdentifier back to com.electron.outline-manager.

Local: [com.electron.outline-manager]

Here are the list of the CFBundleIdentifier of all our released Outline Managers:

1.10.0: [com.electron.outline-manager]
1.11.0: [com.electron.outline-manager]
1.12.0: [com.electron.outline-manager]
1.13.0: [com.electron.outline-manager]
1.14.0: [com.electron.outline-manager]
1.15.0: [com.electron.outline-manager]
1.15.1: [com.electron.outline-manager]
1.15.2: [com.electron.outline-manager]
1.16.0: [com.electron.outlineservermanager]
stable: [com.electron.outlineservermanager]

Note: this change is critical for auto-update, mismatched CFBundleIdentifier will cause auto-update to fail. Let's discuss offline before merging and releasing.

@jyyi1 jyyi1 marked this pull request as ready for review February 20, 2025 02:01
@jyyi1 jyyi1 requested a review from a team as a code owner February 20, 2025 02:01
@jyyi1 jyyi1 requested a review from sbruens February 20, 2025 02:01
@jyyi1 jyyi1 added the do not merge Do not merge the pull request for now. label Feb 20, 2025
@jyyi1 jyyi1 changed the title fix(manager/macos): restore app bundle ID to outline-manager [DO-NOT-MERGE] fix(manager/macos): restore app bundle ID to outline-manager Feb 20, 2025
@fortuna
Copy link
Collaborator

fortuna commented Mar 4, 2025

Where is outlineservermanager coming from?

@jyyi1
Copy link
Contributor Author

jyyi1 commented Mar 4, 2025

Where is outlineservermanager coming from?

https://github.com/Jigsaw-Code/outline-apps/blob/master/server_manager/package.json#L2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniellacosse daniellacosse daniellacosse approved these changes

@sbruens sbruens sbruens approved these changes

Assignees

No one assigned

Labels

do not merge Do not merge the pull request for now. size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jyyi1 @fortuna @daniellacosse @sbruens