Skip to content

Conversation

tiemvanderdeure
Copy link
Contributor

@tiemvanderdeure tiemvanderdeure commented Sep 16, 2025

closes #51

Todo:

  • add tests
  • move WARN_UNORDERED to somewhere more discoverable

Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 7.69231% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.23%. Comparing base (2fa9c55) to head (9b55804).
⚠️ Report is 11 commits behind head on dev.

Files with missing lines Patch % Lines
src/probabilistic.jl 7.69% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #52      +/-   ##
==========================================
- Coverage   91.87%   87.23%   -4.65%     
==========================================
  Files          14       14              
  Lines         714      752      +38     
==========================================
  Hits          656      656              
- Misses         58       96      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tiemvanderdeure tiemvanderdeure marked this pull request as draft September 17, 2025 12:35
"$ContinuousBoyceIndexDoc"
ContinuousBoyceIndex
"$ContinuousBoyceIndexDoc"
cbi(x, y; kw...) = ContinuousBoyceIndex(; kw...)(x, y)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ablaom what would be the right way to go here? I know the other functions don't have this interface, but here I think it would make a lot of sense to allow cbi(ŷ, y; n_bins=5)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you have to make n_bins part of the struct. So you do ContinuousBoyceIndex(nbins=5)(yhat, y).

However, if you want, you can define a pure functional version Functions.continuous_boyce_index here and refactor so that your struct version calls that. And then documentation can point out the core implementation, like we do for MatthewsCorrelation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

continuous boyce index
2 participants