Skip to content

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 18, 2024

This is a hacky workaround for the error seen in JuliaLang/julia#56850. The idea is to move the method to Base, but this can't be done without precompilation errors. We therefore narrow this method, so that the Base method may be added safely before this method is version-limited in this package.

@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (8decfce) to head (5f91cc3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files           6        6           
  Lines         452      452           
=======================================
  Hits          436      436           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 4ffdc70 into master Dec 18, 2024
30 checks passed
@jishnub jishnub deleted the jishnub/reshape_absunitrange_integer branch December 18, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant