Skip to content

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Nov 8, 2022

I knew about the sudo-interpolation-ENV thing, I just have not been good about making PRs for my branches

@DilumAluthge DilumAluthge requested a review from maleadt November 8, 2022 21:15
end

run(sudo(cfg.user, setenv(`$(setenv(juliacmd, nothing)) -e 'using Pkg; Pkg.instantiate(); Pkg.status()'`; dir=builddir)))
run(sudo(cfg.user, `$(setenv(juliacmd, nothing, dir=builddir)) -e 'using Pkg; Pkg.instantiate(); Pkg.status()'`))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to happen in the builddir if its just using the global environment anyway?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it gets moved to sudo either way

@vtjnash
Copy link
Member Author

vtjnash commented Nov 8, 2022

now failing with

│ UndefVarError: benchresults not defined
│ Stacktrace:
│  [1] execute_benchmarks!
│    @ /nanosoldier/Nanosoldier.jl/src/jobs/BenchmarkJob.jl:467

@maleadt
Copy link
Member

maleadt commented Nov 10, 2022

Yeah sorry for the typo's. It's too bad that it's near-impossible to test the benchmark bot, since the code and configuration here is so specific to your set-up (e.g., cset, specific users, etc).

@vtjnash
Copy link
Member Author

vtjnash commented Nov 10, 2022

There is a script to activate a machine as a worker (only do this inside docker, or a machine you actually want to convert though). But not to worry either, as these were pretty simple, and I just run a few trial of nanosoldier whenever I go to update it to check

@vtjnash vtjnash force-pushed the jn/benchmark-updates branch from dfab61e to e641f52 Compare November 10, 2022 21:33
@vtjnash vtjnash force-pushed the jn/benchmark-updates branch from b0142a1 to c926fb4 Compare February 7, 2023 01:55
This makes it easier for anyone with access to log in and view or change the live status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants