-
Notifications
You must be signed in to change notification settings - Fork 64
REST XML Request Functionality #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I haven't been following the development of this package, but note that if |
It's not a direct port from what you had previously proposed. I just made |
482956c
to
ed8d4f8
Compare
- Mock AWS._http_request() - Minor string performance improvements - Formatting styles to align with BlueStyle - AWS sign functions return the request they are modifying - Service URL generation takes in region::String rather than config::AWSConfig - Added return_headers as kwarg for AWS Requests - Added testing for src/AWS.jl functionality
ed8d4f8
to
ddbb488
Compare
TODO
I wanted to get this merge request up for review ASAP, there are some things which I know need to be addressed and can be omitted from being review:
MbedTLS
,Sockets
,XMLDict
src/AWS.jl
functionality;_sign2(), _sign4(), etc.
AWSException.info
Overview
Note this merge request is targeting the
v1
branch, and does not need a version bump or anything of the sorts. This merge request introduces the re-writing for REST XML requests as part of the re-write. It also includes a re-writeAWSConfig
as astruct
proposed by @ararslan here.I think the best way to review this merge request is to look at the commits themselves and not the files changed. The majority of the changes are to auto-generated files such as
src/AWSServices.jl
andsrc/services/*.jl
.Next Steps
The re-write of
AWS.jl
is almost complete, the last few pieces of the puzzle are to:AWSCore.jl
and use the appropriately re-written functionsbors
, and CI, house keeping things