-
Notifications
You must be signed in to change notification settings - Fork 65
Separate unit from integration tests #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maganaluis
approved these changes
Jul 3, 2025
Member
Author
|
Looks like the unit tests are polluting the global AWS configuration: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the switch to using GHA merge queues to deal better with supporting contributions from forks we've discovered a need to run our unit tests and our integration tests separately. By separating these tests we can run the tests which do not require access to the AWS account to be triggered by PR events and reserve the integration tests to be run in the merge queue.
Additionally, this allows for users to run the AWS.jl unit tests locally without any AWS account setup which should allow issues to be caught earlier.
Summary of changes:
test/unitwhere as integration tests reside undertest/integration. For the most part tests were left as is unless changes were required.test/configsdirectory totest/config.test/resourcesdirectory totest/resource.AWS_CONFIGin favor ofglobal_aws_configTEST_MINIOwas renamed toRUN_MINIO_INTEGRATION_TESTSAWSConfig(; creds=nothing, region="...")to create a dummy configDepends on:
Fixes #725