Skip to content

Conversation

@omus
Copy link
Member

@omus omus commented Jul 2, 2025

With the switch to using GHA merge queues to deal better with supporting contributions from forks we've discovered a need to run our unit tests and our integration tests separately. By separating these tests we can run the tests which do not require access to the AWS account to be triggered by PR events and reserve the integration tests to be run in the merge queue.

Additionally, this allows for users to run the AWS.jl unit tests locally without any AWS account setup which should allow issues to be caught earlier.

Summary of changes:

  • Separate existing tests into unit tests and integration tests. Unit tests now reside under test/unit where as integration tests reside under test/integration. For the most part tests were left as is unless changes were required.
  • Rename test/configs directory to test/config.
  • Rename test/resources directory to test/resource.
  • Removed reference AWS_CONFIG in favor of global_aws_config
  • Constant TEST_MINIO was renamed to RUN_MINIO_INTEGRATION_TESTS
  • Unit tests attempt to create an environment where an AWS configuration is not present
  • Unit tests use AWSConfig(; creds=nothing, region="...") to create a dummy config
  • Integration tests are now opt-in instead of opt-out.

Depends on:

Fixes #725

@omus omus changed the base branch from master to cv/aws-profile-config July 2, 2025 19:14
Base automatically changed from cv/aws-profile-config to master July 3, 2025 13:21
@omus omus marked this pull request as ready for review July 3, 2025 13:32
@omus omus added this pull request to the merge queue Jul 3, 2025
@omus
Copy link
Member Author

omus commented Jul 3, 2025

Looks like the unit tests are polluting the global AWS configuration:

RequestError: Could not resolve host: sts.us-example-1.amazonaws.com while requesting https://sts.us-example-1.amazonaws.com/

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2025
@omus omus added this pull request to the merge queue Jul 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2025
@omus omus added this pull request to the merge queue Jul 3, 2025
Merged via the queue into master with commit 314fd47 Jul 3, 2025
5 checks passed
@omus omus deleted the cv/test-reorg branch July 3, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate tests into unit/integration tests

3 participants