Automatically use appropriate region for S3 bucket #740
+291
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
green-nsk
force-pushed
the
s3_bucket_region
branch
from
e6789e3 to
91cdb29
Compare
green-nsk
force-pushed
the
s3_bucket_region
branch
from
91cdb29 to
ca3dbe0
Compare
| using AWS.Compat | ||
| using AWS.UUIDs | ||
|
|
||
| const bucket_regions = Base.Lockable(Dict{String, String}()) |
There was a problem hiding this comment.
This file is auto-generated, any modifications to this file will be undone when service definitions are re-generated.
Here's the beginning entrypoint for service generation where you can then fit these changes into,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing S3 buckets users need to specify a correct region, which seems like something AWS.jl should be able to handle by itself.
In practice, specifying incorrect region in
~/.aws/configresults in 301 redirect, which AWS.jl doesn't handle (issue #397 is created for this). But using the correct bucket to start with seems like more appropriate fix.