Update to JSON v1 #741
Merged
Update to JSON v1 #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
bump, also will this be |
Member
|
I'll correct the CI issue in #743 before merging this. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
Integration tests caught that JSON.jl version 1 no longer exports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the JSON compatibility bounds to 1.0, a JSON breaking release. The biggest difference is that now in version 1 we need to explicitly to treat an
Objectbody as aDict.All tests passed in my fork: lazarusA#1
closes #739 and it will help for unblocking the upgrade also in JuliaIO/Zarr.jl#222