(voodoo) Patch _small_filt_fir!
performance for 1.12
#642
+32
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks show that the previous hack for larger values of
19 <= N <= 66
, effective in Julia 1.9 and 1.10 onwards, fails again in 1.12, but it appears that this can be salvaged again by moving the stores around. This mostly restores the previous level of performance for statelessfilt
s of vectors, but the stateful and array versions may still be left slightly worse in 1.12.Also adjusts theSMALL_FILT_VECT_CUTOFF
, reduced from 19 to 18.Benchmarks included below:
I suppose we should bump the version for this patch?