Skip to content

Conversation

aviatesk
Copy link
Contributor

scoped_identifier has been removed within
tree-sitter/tree-sitter-julia#170.

Also tweaks multiline comment ending pattern
so that it does not insert unnecessary extra
whitespace.

@piechologist piechologist self-assigned this May 28, 2025
Copy link
Collaborator

@piechologist piechologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Just one thing: is there a particular reason to remove the whole blocks for using and import? It would be sufficient to remove the four instances of (scoped_identifier) only.

`scoped_identifier` has been removed within
tree-sitter/tree-sitter-julia#170.

Also tweaks multiline comment ending pattern
so that it does not insert unnecessary extra
whitespace.
@aviatesk aviatesk force-pushed the avi/up-tree-sitter branch from 994d362 to 279209d Compare May 29, 2025 10:13
@aviatesk
Copy link
Contributor Author

Just one thing: is there a particular reason to remove the whole blocks for using and import? It would be sufficient to remove the four instances of (scoped_identifier) only.

Right. Thanks for pointing it out.

Copy link
Collaborator

@piechologist piechologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you very much!

@piechologist
Copy link
Collaborator

I compiled a new julia.wasm locally and can't find any regressions. Plus, the new wasm is 20% smaller and loads a bit faster.

I'll update the Zed Extensions repo later today.

@piechologist piechologist merged commit 0610e9b into JuliaEditorSupport:main May 29, 2025
@aviatesk
Copy link
Contributor Author

Thanks:)

@aviatesk aviatesk deleted the avi/up-tree-sitter branch May 29, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants