Add ParallelFinalReduction for slow reducing operators.
#155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
This PR lets users customize whether or not the final reduction over task results is performed serially or in parallel. My experience so far has been that the overwhelming majority of the time, a serial final reduction is better, but there are cases where
opis slow enough that it makes sense to parallelize, thus there's a new option for this.Here's a demo of functionality with a slow reducing op (matrix multiplication)
Serial final reduction
Parallel final reduction:
and for reference, here's the fully serial reduction:
This is on a 8-core system, so we can see that in this case a parallelized final reduction got us much closer to full thread utilization, but we're still a ways off here due to effects like GC and spawning more tasks than actually necessary.
cc @kpamnany who asked about this at JuliaCon
TODO: