Skip to content

Add error checking to command buffer completion handler #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 3, 2025
+7 −3
Merged

Add error checking to command buffer completion handler #521

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4179f1f
Add error checking to command buffer completion handler
vovw Jan 20, 2025
be41ab8
fix fmt
vovw Jan 20, 2025
96808ca
add test and fight with fmt
vovw Jan 21, 2025
60996c6
Format and fix test.
maleadt Jan 27, 2025
804a4b5
runic fmt
vovw Jan 29, 2025
3c9c87a
Simplify.
maleadt Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/compiler/execution.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,14 @@ end
empty!(roots)
foreach(free, argument_buffers)

# TODO: access logs here to check for errors
# https://developer.apple.com/videos/play/wwdc2020/10616/
end
# Check for errors
# XXX: we cannot do this nicely, e.g. throwing an `error` or reporting with `@error`
# because we're not allowed to switch tasks from this contexts.
if buf.status == MTL.MTLCommandBufferStatusError
Core.println("ERROR: Failed to submit command buffer: $(buf.error.localizedDescription)")
end

end
commit!(cmdbuf)
end

Expand Down