Skip to content

Use constructed gridchunks and add tests #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2025
Merged

Use constructed gridchunks and add tests #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dec4204
Use constructed gridchunks
felixcremer Oct 8, 2025
1698d63
Add mockchunks tests
felixcremer Oct 8, 2025
c248bc4
Add size tuple mockchunks test
felixcremer Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mockchunks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function mockchunks(data::AbstractArray, chunks)
else
GridChunks(data, chunks)
end
MockChunkedDiskArray(data, GridChunks(data, chunks))
MockChunkedDiskArray(data, gridchunks)
end


Expand Down
12 changes: 12 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,3 +1132,15 @@ end
@inferred DiskArrays.DiskIndex(a_view5, (1:1, 1:1, 1:1, 1:1, 1:1), DiskArrays.NoBatch()) #DiskArrays.DiskIndex
@inferred DiskArrays.DiskIndex(a_view6, (1:1, 1:1, 1:1, 1:1, 1:1, 1:1), DiskArrays.NoBatch()) #DiskArrays.DiskIndex
end

@testset "mockchunks" begin
a =UnchunkedDiskArray(rand(10,10))
chunks = DiskArrays.RegularChunks.((5,5), (0,0), (10,10))
gchunks = DiskArrays.GridChunks(chunks)
a_chunked = DiskArrays.mockchunks(a, gchunks)
@test a_chunked isa DiskArrays.MockChunkedDiskArray
@test size(DiskArrays.eachchunk(a_chunked)) == (2,2)
a_chunked_2 = DiskArrays.mockchunks(a, (2,2))
@test DiskArrays.haschunks(a_chunked_2) isa DiskArrays.Chunked
@test size(DiskArrays.eachchunk(a_chunked_2)) == (5,5)
end