[DO NOT MERGE] Use UInt64 for encoding size #270
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachdavi
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #270 +/- ##
=======================================
Coverage 93.42% 93.42%
=======================================
Files 25 25
Lines 2997 2997
=======================================
Hits 2800 2800
Misses 197 197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Drvi
reviewed
Jun 12, 2025
| @@ -1,5 +1,5 @@ | |||
| function encode_tag(io::IO, field_number, wire_type::WireType) | |||
| vbyte_encode(io, (UInt32(field_number) << 3) | UInt32(wire_type)) | |||
| vbyte_encode(io, (UInt64(field_number) << 3) | UInt64(wire_type)) | |||
There was a problem hiding this comment.
I don't think you need this change
| encode_tag(e, i, START_GROUP) | ||
| encode(e, el) # This method has to be generated by protojl | ||
| vbyte_encode(e.io, UInt32(END_GROUP)) | ||
| vbyte_encode(e.io, UInt64(END_GROUP)) |
There was a problem hiding this comment.
I don't think you need this change
| encode_tag(e, i, START_GROUP) | ||
| encode(e, x) # This method has to be generated by protojl | ||
| vbyte_encode(e.io, UInt32(END_GROUP)) | ||
| vbyte_encode(e.io, UInt64(END_GROUP)) |
There was a problem hiding this comment.
I don't think you need this change
Drvi
changed the title
Drvi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run into truncation problems because the encoding size is a
UInt32. This PR does not necessarily need to be merged, we mostly want to unblock ourselves.