Skip to content

Conversation

@bjarthur
Copy link
Contributor

it's orders of magnitude faster. still working on getting your benchmark scripts to work on my machine. let me know what you think and i'll add tests and docs.

@bjarthur
Copy link
Contributor Author

bjarthur commented Mar 11, 2025

here's a little ad-hoc benchmark script:

using DiskArrays, ImageMorphology, Zarr
a = rand(Bool, 256,256,256);
z = ZArray(a);
oa = similar(a);
oz = similar(z);
se = strel_diamond((3, 3, 3));
erode!(oa, a, se);
erode!(oz, z, se);

you have to manually run it on master and this PR. on master it will essentially hang forever on the last line. returns essentially immediately with this PR.

@bjarthur
Copy link
Contributor Author

@rafaqz

@bjarthur bjarthur marked this pull request as draft March 19, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant