Skip to content

Conversation

@dkarrasch
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (924dda4) to head (1b46536).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1197      +/-   ##
==========================================
- Coverage   91.90%   91.86%   -0.04%     
==========================================
  Files          34       34              
  Lines       15371    15365       -6     
==========================================
- Hits        14126    14115      -11     
- Misses       1245     1250       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevengj
Copy link
Member

stevengj commented Feb 8, 2025

LGTM. (Seems like both previous and new versions are type-unstable, but not sure how to fix that without putting uplo as a type parameter.)

@dkarrasch
Copy link
Member Author

Yes, this is as good/bad as it always was. It just makes the outer wrapper explicit. Before, it was implicitly changed by the outer adjoint.

@dkarrasch dkarrasch merged commit 5aca26f into master Feb 8, 2025
3 of 4 checks passed
@dkarrasch dkarrasch deleted the dk/prop_cholesky branch February 8, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants