Skip to content

Simplify getproperty for Cholesky* #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Simplify getproperty for Cholesky* #1197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 5 additions & 20 deletions src/cholesky.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,30 +664,15 @@ copy(C::CholeskyPivoted) = CholeskyPivoted(copy(C.factors), C.uplo, C.piv, C.ran
size(C::Union{Cholesky, CholeskyPivoted}) = size(C.factors)
size(C::Union{Cholesky, CholeskyPivoted}, d::Integer) = size(C.factors, d)

function _choleskyUfactor(Cfactors, Cuplo)
if Cuplo === 'U'
return UpperTriangular(Cfactors)
else
return LowerTriangular(Cfactors)'
end
end
function _choleskyLfactor(Cfactors, Cuplo)
if Cuplo === 'L'
return LowerTriangular(Cfactors)
else
return UpperTriangular(Cfactors)'
end
end

function getproperty(C::Cholesky, d::Symbol)
Cfactors = getfield(C, :factors)
Cuplo = getfield(C, :uplo)
if d === :U
_choleskyUfactor(Cfactors, Cuplo)
UpperTriangular(Cuplo == 'U' ? Cfactors : Cfactors')
elseif d === :L
_choleskyLfactor(Cfactors, Cuplo)
LowerTriangular(Cuplo == 'L' ? Cfactors : Cfactors')
elseif d === :UL
return (Cuplo === 'U' ? UpperTriangular(Cfactors) : LowerTriangular(Cfactors))
return (Cuplo == 'U' ? UpperTriangular(Cfactors) : LowerTriangular(Cfactors))
else
return getfield(C, d)
end
Expand All @@ -704,9 +689,9 @@ function getproperty(C::CholeskyPivoted{T}, d::Symbol) where {T}
Cfactors = getfield(C, :factors)
Cuplo = getfield(C, :uplo)
if d === :U
_choleskyUfactor(Cfactors, Cuplo)
UpperTriangular(Cuplo == 'U' ? Cfactors : Cfactors')
elseif d === :L
_choleskyLfactor(Cfactors, Cuplo)
LowerTriangular(Cuplo == 'L' ? Cfactors : Cfactors')
elseif d === :p
return getfield(C, :piv)
elseif d === :P
Expand Down