Skip to content

Let cond of an empty square matrix return zero #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Let cond of an empty square matrix return zero #1169

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
602578d
Let `cond` of an empty square matrix return zero
martinholters Nov 10, 2020
3142a5e
DRY up test with `for` loops
martinholters Jan 27, 2025
507cb3b
Rename `norm` to `p` in tests
martinholters Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/dense.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1779,6 +1779,10 @@ Condition number of the matrix `M`, computed using the operator `p`-norm. Valid
"""
function cond(A::AbstractMatrix, p::Real=2)
if p == 2
if isempty(A)
checksquare(A)
return zero(real(eigtype(eltype(A))))
end
v = svdvals(A)
maxv = maximum(v)
return iszero(maxv) ? oftype(real(maxv), Inf) : maxv / minimum(v)
Expand Down
19 changes: 19 additions & 0 deletions test/dense.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,25 @@ Random.seed!(1234323)
@test cond(Mars, 2) ≈ 6.181867355918493
@test cond(Mars, Inf) ≈ 7.1
end
@testset "Empty matrices" begin
# zero for square (i.e. 0×0) matrices
@test cond(zeros(Int, 0, 0), 1) === 0.0
@test cond(zeros(Int, 0, 0), 2) === 0.0
@test cond(zeros(Int, 0, 0), Inf) === 0.0
@test cond(zeros(0, 0), 1) === 0.0
@test cond(zeros(0, 0), 2) === 0.0
@test cond(zeros(0, 0), Inf) === 0.0
@test cond(zeros(ComplexF64, 0, 0), 1) === 0.0
@test cond(zeros(ComplexF64, 0, 0), 2) === 0.0
@test cond(zeros(ComplexF64, 0, 0), Inf) === 0.0
# error for non-square matrices
@test_throws DimensionMismatch cond(zeros(10, 0), 1)
@test_throws DimensionMismatch cond(zeros(0, 10), 1)
@test_throws DimensionMismatch cond(zeros(10, 0), 2)
@test_throws DimensionMismatch cond(zeros(0, 10), 2)
@test_throws DimensionMismatch cond(zeros(10, 0), Inf)
@test_throws DimensionMismatch cond(zeros(0, 10), Inf)
end
end

areal = randn(n,n)/2
Expand Down
Loading