Fix some tests when run in base #4499
Open
+203
−192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of JuliaLang/julia#60058. When we don't have a log file setup, the default IO is set to devnull. However, this causes `Pkg.status` to early out and skip some validity checks that we are testing for. Fix this by passing an appropriate io directly to the API. For the REPL test, which don't have an IO argument, override the global default IO, but to make that more robust also switch it to a ScopedValue (which Pkg is already using elsewhere).
KristofferC
reviewed
Nov 14, 2025
ext/REPLExt/precompile.jl
Outdated
| repl = REPL.LineEditREPL(term, true) | ||
| REPL.run_repl(repl) | ||
| repl_init(repl) | ||
| @Base.ScopedValues.with Pkg.DEFAULT_IO => Pkg.unstableio(devnull) begin |
Member
There was a problem hiding this comment.
These even syntax highlights badly :P. I'm sure runic will complain about this at some point so might as well sawp it now heh.
Member
Author
There was a problem hiding this comment.
FWIW, I don't really agree that the other macrocall form is preferable, but I'm ok to change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of JuliaLang/julia#60058. When we don't have a log file setup, the default IO is set to devnull. However, this causes
Pkg.statusto early out and skip some validity checks that we are testing for. Fix this by passing an appropriate io directly to the API. For the REPL test, which don't have an IO argument, override the global default IO, but to make that more robust also switch it to a ScopedValue (which Pkg is already using elsewhere).