Skip to content

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented May 24, 2024

Note: the base branch (target branch) of this PR is kc/warn_using (#42080), NOT master.

The base branch of this PR used to be kc/warn_using (#42080), but now it's master.


This small change was originally part of #53428. However, it caused confusion during PR review. So I removed this change from #53428 (in 862a546), and I've put that change into this PR.

Just to clarify, the language about "keeping the namespace clean" already existed on master prior to #53428 (and prior to this PR). All this PR does is:

  1. Move the existing "clean namespace" sentence down.
  2. In that existing sentence, change "import ModuleName" to "import ModuleName or using ModuleName: ModuleName".

@KristofferC KristofferC force-pushed the dpa/small-change-module-qualified-names branch from f6e4e5c to d825d98 Compare May 29, 2024 13:26
@KristofferC KristofferC added docs This change adds or pertains to documentation merge me PR is reviewed. Merge when all tests are passing labels May 29, 2024
@DilumAluthge DilumAluthge changed the base branch from master to kc/warn_using June 3, 2024 18:41
@DilumAluthge DilumAluthge force-pushed the dpa/small-change-module-qualified-names branch from d825d98 to bce50b3 Compare June 3, 2024 18:41
@DilumAluthge
Copy link
Member Author

Ugh. I've borked the rebase. I'll fix it.

@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jun 3, 2024
@DilumAluthge DilumAluthge force-pushed the dpa/small-change-module-qualified-names branch from bce50b3 to b4dd31f Compare June 4, 2024 00:07
@DilumAluthge
Copy link
Member Author

Okay, I think I've fixed the rebase now.

@DilumAluthge DilumAluthge marked this pull request as ready for review June 4, 2024 00:07
@DilumAluthge DilumAluthge added packages Package management and loading modules labels Jun 4, 2024
@DilumAluthge DilumAluthge force-pushed the dpa/small-change-module-qualified-names branch from b4dd31f to 15a8791 Compare June 6, 2024 00:55
@DilumAluthge DilumAluthge force-pushed the dpa/small-change-module-qualified-names branch from 15a8791 to 8bd8c35 Compare June 29, 2024 05:47
Base automatically changed from kc/warn_using to master October 26, 2024 01:01
@DilumAluthge DilumAluthge force-pushed the dpa/small-change-module-qualified-names branch from 8bd8c35 to f92c4a5 Compare August 31, 2025 19:53
@ViralBShah ViralBShah added the merge me PR is reviewed. Merge when all tests are passing label Oct 13, 2025
@adienes adienes merged commit 79d7300 into master Oct 19, 2025
7 checks passed
@adienes adienes deleted the dpa/small-change-module-qualified-names branch October 19, 2025 00:44
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs This change adds or pertains to documentation modules packages Package management and loading

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants