-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add Base.active_manifest()
#57937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Base.active_manifest()
#57937
Conversation
|
Maybe it should optionally take a project and give the manifest for that (defaulting to the active project). |
|
|
|
See the label and
|
IMO it makes sense to return |
|
How does this function behave with regards to versioned manifest filenames? |
To clarify my opinion, I think it's good that this PR currently returns |
|
I still think that this would be nice to have. @IanButterworth @KristofferC What do you think? |
|
Feel free to take it over |
f8e6ba0 to
69f15a4
Compare
|
Ah, I should have left in "draft" - still needs tests. |
|
Has tests now. |
a14ab9f to
48b92ce
Compare
Co-authored-by: Ian Butterworth <[email protected]>
48b92ce to
923f617
Compare
Closes #57924
I'm holding off adding tests because I wasn't sure whether that last case should match
active_projectand return a path to a nonexistant file? i.e. the tempProject.tomldoesn't exist, nor manifest.