Skip to content

Markdown: fix string interpolation #59806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

Markdown: fix string interpolation #59806

merged 1 commit into from
Oct 15, 2025

Conversation

@barucden
Copy link
Contributor

Fixes #59783

@KristofferC KristofferC added the merge me PR is reviewed. Merge when all tests are passing label Oct 15, 2025
KristofferC
KristofferC approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@KristofferC KristofferC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barucden
Copy link
Contributor Author

Thank you, Kristoffer.

Markdown failed to precompile before the force-push due to something with JuliaSyntaxHighlighting. It was happening to me locally too, but I just assumed it was something with my environment. It is not happening anymore, but I'd suggest to wait for the tests to pass anyway.

@barucden
Copy link
Contributor Author

Okay, I think it's good now. The test failures are #59846.

@KristofferC KristofferC added the backport 1.12 Change should be backported to release-1.12 label Oct 15, 2025
@KristofferC KristofferC merged commit 20c787d into JuliaLang:master Oct 15, 2025
7 of 9 checks passed
KristofferC pushed a commit that referenced this pull request Oct 16, 2025
@barucden @KristofferC
Markdown: fix string interpolation (#59806)
be35825 
(cherry picked from commit 20c787d)
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Oct 17, 2025
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KristofferC KristofferC KristofferC approved these changes

Assignees

@vtjnash vtjnash

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Interpolation within @md_str in admonitions and footnotes does not work

4 participants

@barucden @KristofferC @vtjnash @DilumAluthge