re-allow implicit prevfloat for signed step sizes
#59836
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually, this introduces ambiguities if someone defines I guess it's better to just tell / help the packages to adapt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#59668 changed
prevfloat(x, d)to no longer just callnextfloat(x, -d), so as to avoid bugs resulting from intermediate overflow whendis unsigned.as predicted in #59668 (comment) and then observed in #59668 (comment), this causes some package failures. The failures are exposing a bug, so it's ultimately a good thing, but this PR would restore the old behavior at least when
d isa Signedand only fails when we'd actually hit the unsigned buggy case.