fix: trigger error hints on exception supertypes too

[gdalle]

Fixes #58367

[tecosaur]

I'm afraid I can't offer a full review, but I do want to say that I love module Hinterland in the tests 😆

[DilumAluthge]

@vtjnash Could you review this?

[DilumAluthge]

And maybe also @timholy?

[gdalle]

Crap, I struggled with the master build on my Mac so I didn't test locally but judging by CI it seems that

UndefVarError: `supertypes` not defined in `Base.Experimental`

which makes sense since supertypes comes from the InteractiveUtils stdlib. Is this approach doomed to fail?

[tecosaur]

which makes sense since supertypes comes from the InteractiveUtils stdlib. Is this approach doomed to fail?

Not at all, you can still use supertype in a while loop.

[DilumAluthge]

@vtjnash Can you do another review?

[DilumAluthge]

@gdalle I think the CI failures are related to this PR. Are you able to build this PR branch locally?

rror during bootstrap:
LoadError("sysimg.jl", 3, LoadError("Base.jl", 251, LoadError("experimental.jl", 303, UndefVarError(:TypeName, 0x0000000000006487, Base.Experimental))))
ijl_undefined_var_error at [buildroot]/src/rtutils.c:167

[DilumAluthge]

The Build jobs are hanging on CI, reproducible after a retry. Master is green, so this seems related to the PR.

[DilumAluthge]

Last time I tried the Julia build showed errors on my Mac M3, which is why I didn't test locally. Not sure if this is expected or not with the current master

Hmmm, we generally expect that you can build master locally. What's the error you get? We may need to open a new issue.

@gdalle Try building master first, before you try building this PR.

I just confirmed that I can successfully build master (c1353ac) locally on an M2 MacBook.

[DilumAluthge]

@vtjnash Any idea why this PR would cause a hang when building Julia?

[gdalle]

I'll try building tomorrow and report back. Hope we can sneak this into 1.13

[gdalle]

I tried to build locally, master works but this PR fails. It runs for really long and then crashes my console. I don't know how to see the error on the buildkite logs, where should I look?

[tecosaur]

I just took a look at the builtkite logs

Seems like the builds are failing because they're timing out.

[gdalle]

Could it be an infinite while loop here?

while ex_supertype != Any

That seems unlikely but it is the only reason I can think of for a timeout

[abraemer]

Seems unlikely but also easy to check: You could keep track of types you have already seen and then abort the loop once supertype gives you a type you saw already. That would cover any sorts of strange loops.

Perhaps simpler for debugging: Keep track of the number of iterations and if it exceeds e.g. 20 or so then you log the type and abort the loop.

[gdalle]

I figured it out: the shortcut isnothing(hinters) && continue did not replace ex_supertype with its supertype, so it did not make any progress towards Any. That's what was triggering the infinite loop

[DilumAluthge]

Error in testset errorshow:
Error During Test at /cache/build/tester-amdci4-8/julialang/julia-master/julia-8cb1702aa9/share/julia/test/testdefs.jl:25

[gdalle]

Oh right, the test suite is doing some weird popping so that the length doesn't stay even. I'll fix it tomorrow

[gdalle]

Now my new test is passing but some older tests are failing, partly because the error prints more than it used to 🤔

[gdalle]

Why was this merged despite breaking CI?

[vtjnash]

CI said it passed

[gdalle]

Okay, it seems that the buildkite failure is unrelated then