subtype: use bitvector API for bits stack access #59866
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace "manual" bitmask operations in `statestack_get()` and `statestack_set()` with the API provided by bitvector to reduce duplication of bit maipulation logic. In addition let's make the bit operations in bitvector to use unsigned constants for type consistency with `uint` data.
|
ah it fails because of safepoints, sorry for noise. Closing this PR for now as I am not so familiar with the code base and not sure should be bitvector API marked with notsafepoint or not. |
|
It can be done by annotating |
|
Fortunately, those annotations are themselves also checked for correctness, so there is no risk to adding them |
So should I re-open PR? |
|
Up to you. It seems to be NFC, but it seems a valid simplification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace "manual" bitmask operations in
statestack_get()andstatestack_set()with the API provided by bitvector to reduce duplication of bit maipulation logic.In addition let's make the bit operations in bitvector to use unsigned constants for type consistency with
uintdata.