fix accidental save (and restore) of sigmask when interpreting try #59878
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed during bug hunting of ericphanson/LicenseCheck.jl#11 (comment) and may cause performance degradation for interpreter-executed try blocks or scope entry.
staticfloat
approved these changes
Oct 17, 2025
giordano
added
system:mac
|
Note that this is a confusing one, since the officially published source code that Apple claims is being run does not have this bug (apple-oss-distributions/libplatform@main...rel/libplatform-349), but is also very clearly not the code that is actually present in libsystem_platform.dylib via disassembly, which is mostly similar but has more pointer authentication code. That code is APSL licensed, so Apple can do whatever they want there, just confusing to have them seemingly intentionally misrepresent which code is being used. And it just happens to be in our favor, performance-wise, to disable executing the buggy function. |
DilumAluthge
removed
the
merge me
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2025
…59878) Noticed during bug hunting of ericphanson/LicenseCheck.jl#11 (comment) and may cause performance degradation for interpreter-executed try blocks or scope entry. Co-authored-by: Dilum Aluthge <[email protected]> (cherry picked from commit c1353ac)
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2025
…59878) Noticed during bug hunting of ericphanson/LicenseCheck.jl#11 (comment) and may cause performance degradation for interpreter-executed try blocks or scope entry. Co-authored-by: Dilum Aluthge <[email protected]> (cherry picked from commit c1353ac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed during bug hunting of
ericphanson/LicenseCheck.jl#11 (comment) and may cause performance degradation for interpreter-executed try blocks or scope entry.