Move .PHONY statements in Makefiles and add missing ones
#60075
Merged
+134
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way it is much easier to see which targets are PHONY and which aren't (and thus also which are not but should be)
Keno
reviewed
Nov 9, 2025
test/Makefile
Outdated
| TEST_JULIA_OPTIONS := --check-bounds=yes --startup-file=no --depwarn=error | ||
| TEST_SCRIPT_OPTIONS := --buildroot=$(call cygpath_w,$(BUILDROOT)) | ||
|
|
||
| default |
Member
Author
There was a problem hiding this comment.
Indeed, thanks, fixed. not sure what happened there.
fingolfin
commented
Nov 9, 2025
fingolfin
commented
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves most
.PHONYstatements in ourMakefiles next to the target they are marking as phony. This then makes it easy to spot those targets which clearly should be marked as phony but aren't. Subsequently this is then resolved.Also some
.PHONYstatements for targets that do not exist anymore are also removed.