Skip to content

Term hist UI tweaks #60076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Term hist UI tweaks #60076

wants to merge 3 commits into from
+36 −20

Conversation

@tecosaur
Copy link
Member

@tecosaur tecosaur commented Nov 7, 2025 •
edited
Loading

This is a small collection of (what I consider) innocuous fixes/tweaks to the history UI.

If anything is bikesheddable, I'll split it off into a separate PR.

Closes: #60036

@tecosaur tecosaur added REPL Julia's REPL (Read Eval Print Loop) display and printing Aesthetics and correctness of printed representations of objects. stdlib Julia's standard library don't squash Don't squash merge labels Nov 7, 2025
@tecosaur tecosaur marked this pull request as ready for review November 7, 2025 12:57
@tecosaur
Copy link
Member Author

tecosaur commented Nov 7, 2025

I think this should be good to merge as soon as CI finishes if nothing comes up

@tecosaur tecosaur force-pushed the term-hist-ui-tweaks branch from 39bbce5 to 89311e5 Compare November 7, 2025 13:00
@KristofferC
Copy link
Member

KristofferC commented Nov 7, 2025

Skip consecutive identical history records in UI

Consecutive duplicates doesn't have any more semantic meaning to me compared to non-consecutive if you are filtering so I don't understand the justification for this over filtering out all duplicated entries.

@tecosaur
Copy link
Member Author

tecosaur commented Nov 7, 2025

Consecutive duplicates doesn't have any more semantic meaning to me compared to non-consecutive if you are filtering so I don't understand the justification for this over filtering out all duplicated entries.

I'm not arguing for consecutive deduplication instead of unique, I just think there's a bit more to consider/check for deduplication for uniqueness, and so might as well get rid of consecutive duplicates in the meantime, since it's uncomplicated.

@tecosaur
Copy link
Member Author

tecosaur commented Nov 7, 2025

There's one more fix I'll plop here if I can figure it out today

@tecosaur tecosaur force-pushed the term-hist-ui-tweaks branch 2 times, most recently from a567ecf to 9264293 Compare November 7, 2025 14:14
@tecosaur
Fix string indexing with repl history filters
8f0f822 
String indexing is such fun 🙃
@tecosaur
Retire > history search mode in favour of prefix>
e117413 
This allows for search strings to be typed out as they are at the REPL,
e.g. "julia> test123" (only in word mode). This seems natural enough
that the > search mode is no longer needed.
@tecosaur
Fix ;-escaping in the final history search segment
34bbe85 
Let's also avoid copying the entirety of `str` when dropping escaped
characters while I'm at it.
@tecosaur tecosaur force-pushed the term-hist-ui-tweaks branch from 9264293 to 34bbe85 Compare November 7, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees

No one assigned

Labels

backport 1.13 display and printing Aesthetics and correctness of printed representations of objects. don't squash Don't squash merge REPL Julia's REPL (Read Eval Print Loop) stdlib Julia's standard library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

StringIndexError: invalid index in new History search

3 participants

@tecosaur @KristofferC @fingolfin