loading.jl: Make slug internally type-stable
#60134
Merged
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to `divrem` used to change the type of `x` (previously `y`) from `UInt32` to `UInt64` on 64-bit systems. Avoid this. (No externally visible change.)
StefanKarpinski
approved these changes
Nov 14, 2025
Contributor
Author
|
There is a weird and unrelated error for |
Member
|
I think this can be merged anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
divremused to change the type ofx(previouslyy) fromUInt32toUInt64on 64-bit systems. Avoid this. (No externally visible change.)