[JuliaLowering] Fix placeholders in parameters and decls, work around hasmethod
#60140
+135
−47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from c42f/JuliaLowering.jl#99
Fix placeholders in positional and keyword arguments.
way we desugar keyword functions; give them an internal name. (fix https://github.com/c42f/JuliaLowering.jl/issue/55, port Allow underscore (unused) args in presence of kwargs #58803)
kws...may use a placeholder (fix https://github.com/c42f/JuliaLowering.jl/issue/49)Allow placeholders in decls:
local/global _,local/global _::T. Thiscan be produced by destructuring assignments. I've implemented this to
always drop the type (see Assignment to
_sets the binding type of_#57497),but this may not be what we want.
Work around
hasmethodalways returning false forworld=typemax(UInt)(somediscussion here). I'm not sure we should be using
hasmethodin the first place.Comment out our
@atomicimplementation. We need to implement this for allforms that the normal
@atomictakes, otherwise it hijacks the expansion andexpects a simple form.