Skip to content

Conversation

@mlechu
Copy link
Member

@mlechu mlechu commented Nov 14, 2025

Moved from c42f/JuliaLowering.jl#99


  • Fix placeholders in positional and keyword arguments.

  • Allow placeholders in decls: local/global _, local/global _::T. This
    can be produced by destructuring assignments. I've implemented this to
    always drop the type (see Assignment to _ sets the binding type of _ #57497),
    but this may not be what we want.

  • Work around hasmethod always returning false for world=typemax(UInt) (some
    discussion here). I'm not sure we should be using hasmethod in the first place.

  • Comment out our @atomic implementation. We need to implement this for all
    forms that the normal @atomic takes, otherwise it hijacks the expansion and
    expects a simple form.

@mlechu mlechu requested a review from c42f November 14, 2025 23:12
@mlechu mlechu changed the title Fix placeholders in parameters and decls, work around hasmethod [JuliaLowering] Fix placeholders in parameters and decls, work around hasmethod Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant