Skip to content

Conversation

@kylebeggs
Copy link
Member

@kylebeggs kylebeggs commented Feb 4, 2025

Closes #32

  • Increases the default number of neighbors to 10
  • Requires split angle to be a Unitful.jl angle

@kylebeggs
Copy link
Member Author

Might also take the time to do some optimizations here in the latter part of split_surface! such as in ranges_from_permutation. It is a bit naive.

@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/discretization/algorithms/fornberg_flyer.jl 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/WhatsThePoint.jl 100.00% <100.00%> (ø)
.../discretization/algorithms/vandersande_fornberg.jl 95.12% <100.00%> (ø)
src/surface_operations.jl 64.81% <100.00%> (+0.66%) ⬆️
src/discretization/algorithms/fornberg_flyer.jl 0.00% <0.00%> (ø)

@kylebeggs kylebeggs merged commit 65df3b4 into main Feb 11, 2025
10 checks passed
@kylebeggs kylebeggs deleted the split_surfaces branch February 11, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

split surface not working correctly

2 participants