Add a precompilation workload #263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If big float support broke because of the NLSolversBase release we should bound the version that is supported by v.0.15.x of LsqFit.jl |
|
It would indeed be interesting to know whether it worked prior to the recent changes. I saw that @lcontento had encountered the seemingly same issue (I opened a PR with a fix to ForwardDiff) in NLsolve 5 years ago: JuliaDiff/ForwardDiff.jl#436 |
|
Yeah it worked because NLSolversBase used |
|
Okay, forgetting the ForwardDiff errors we can include this, but we need to bump Julia to v1.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my system this reduces the time taken for a subset of the curve fitting tests from ~12.5s to ~2.5s.
Note that support for BigFloat's is currently broken with NLSolversBase 7.9 so CI won't pass (hacky fix here JuliaNLSolvers/NLSolversBase.jl#160, but @gdalle kindly agreed to look into it further).