Doc update #576
Merged
Doc update #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm... This was not enough to fix it to get it working on my machine for some reason. Strange. I will make it a more robust fix with a filter so that if the number changes in the future. I do think the doctests add value because it ensures that old incorrect code does not make it into the doc examples. (but maybe an In any case, THANK YOU @dylan-asmar for fixing! |
|
There was also an issue with TagPOMDPProblem that might have been causing an error after you fixed this one. There was a compat problem with MetaGraphs (needed 0.8) I do agree that doctests are useful and awesome. I was just saying for that particular block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #575
There was a
jldoctestthat had an incorrect function identifier. For those code blocks, I don't think thejldoctestis providing us any value, but kept it in for now and udpated it.